In a a pre-Gen5 (or G30) slide-stop, the problem typically is caused by improper installation of the slide-stop and locking-block-pin.
Most likely, the locking block pin was not installed prior to putting the slide stop into place, then inserting the trigger pin through the frame, trigger, and slide-stop. This can occur when someone has removed the locking block pin for some reason.
Another cause is the slide-stop spring actually breaking. Inserting the locking-block-pin after the slide-stop was put into place can also pinch or bend the slide-stop's spring, which may cause the spring to later break. With insufficient spring tension, the slide stop will continually lock back the slide without a mag follower pushing the slide-stop up.
Any bending of the slide-stop spring is not the fix.