The best gunsmith I know is asked this all the time. His advice is to become a machinist first. A lot of the money is in things far more advanced than just replacing parts and repairs.
Some guys on here have strongly disagreed with me on this but he builds a very strong argument for doing it his way if you want to make a GOOD living at it.
If it can't get you in trouble, it's not an adventure.